-
Notifications
You must be signed in to change notification settings - Fork 132
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: refactor Action Bar title to follow the latest fund-styles (#3466)
BREAKING CHANGE: fd-action-bar-title directive is now a component.
- Loading branch information
1 parent
8fdfed0
commit 5d80c05
Showing
13 changed files
with
45 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
...core/component-docs/action-bar/examples/action-bar-contextual-menu-example.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...src/app/core/component-docs/action-bar/examples/action-bar-no-back-example.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 3 additions & 4 deletions
7
...-title/action-bar-title.directive.spec.ts → ...-title/action-bar-title.component.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
libs/core/src/lib/action-bar/action-bar-title/action-bar-title.component.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { ChangeDetectionStrategy, Component, ViewEncapsulation } from '@angular/core'; | ||
|
||
/** | ||
* The action bar title component. | ||
* | ||
* ```html | ||
* <fd-action-bar> | ||
* <div fd-action-bar-header> | ||
* <div fd-action-bar-title>Page Title</div> | ||
* </div> | ||
* <fd-action-bar> | ||
* ``` | ||
*/ | ||
@Component({ | ||
// tslint:disable-next-line:component-selector | ||
selector: '[fd-action-bar-title]', | ||
template: ` | ||
<h2 class="fd-title fd-title--h3"> | ||
<ng-content></ng-content> | ||
</h2> | ||
`, | ||
host: { | ||
class: 'fd-action-bar__title' | ||
}, | ||
encapsulation: ViewEncapsulation.None, | ||
changeDetection: ChangeDetectionStrategy.OnPush | ||
}) | ||
export class ActionBarTitleComponent {} |
21 changes: 0 additions & 21 deletions
21
libs/core/src/lib/action-bar/action-bar-title/action-bar-title.directive.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
@import '~fundamental-styles/dist/action-bar'; | ||
@import '~fundamental-styles/dist/title'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
export * from './action-bar.module'; | ||
export * from './action-bar.component'; | ||
export * from './action-bar-title/action-bar-title.component'; | ||
export * from './action-bar-actions/action-bar-actions.directive'; | ||
export * from './action-bar-description/action-bar-description.directive'; | ||
export * from './action-bar-header/action-bar-header.directive'; | ||
export * from './action-bar-title/action-bar-title.directive'; | ||
export * from './action-bar-back/action-bar-back.directive'; | ||
export * from './action-bar-mobile/action-bar-mobile.directive'; |