Ability to setup hotkeys to cycle through controllers

[SomeoneIsWorking]

What this does is you can add/remove hotkeys for players to cycle through controllers.
Reasons I made this.

• Sometimes Player 1 is set to disabled by itself (when started with controller off, Isaac had a fix PR for this but I don't know if it's implemented).
• My son sometimes plays co-op with a single controller and sometimes plays co-op with us so we can cycle Player 2 based on it.
• On ROG Ally, I can easily switch between handheld controller and external controller.

KNOWN ISSUES

• Toast message not displaying when game is being rendered. I don't know how to fix it. I think it's related to Avalonia and the render component and the render component is rendering on top of the toast.

NOTES

• Hotkeys don't work before starting a game. The only time where both this works and the toast is visible is if you press it while the emulator is loading the game. The keys will work during gameplay but toast won't be visible due to the issue.

UPDATES NEEDED

• "Player X" isn't localized.
• Layout could be better.

POSSIBLE OTHER UPDATES

• Currently this relies on calling a ViewModel because controller logic is tied into it which is not 100% ideal so maybe that can be decoupled.

Edits

Screenshot from latest build

[github-actions]

Download the artifacts for this pull request:

• ryujinx-Release-1.2.0+9a7f560-macos_universal
• ryujinx-Release-1.2.0+9a7f560-linux_arm64
• ryujinx-Release-1.2.0+9a7f560-linux_arm64-AppImage
• ryujinx-Release-1.2.0+9a7f560-linux_x64
• ryujinx-Release-1.2.0+9a7f560-linux_x64-AppImage
• ryujinx-Release-1.2.0+9a7f560-win_x64

Only for Developers

• ryujinx-Debug-1.2.0+9a7f560-linux_arm64
• ryujinx-Debug-1.2.0+9a7f560-linux_arm64-AppImage
• ryujinx-Debug-1.2.0+9a7f560-macos_universal
• ryujinx-Debug-1.2.0+9a7f560-linux_x64
• ryujinx-Debug-1.2.0+9a7f560-linux_x64-AppImage
• ryujinx-Debug-1.2.0+9a7f560-win_x64

[VeraPhobia]

i downloaded the artifact but i cant find the option to test it out

[SomeoneIsWorking]

@VeraPhobia Yes, I just noticed, I think I messed up the rebase and I can't get the code back anymore so I'll try to do it again.

Edit: Thank VSCode local history, I was able to restore it.

This is how it should look like now.

[VeraPhobia]

extremely minor details but it would look better if the text and fields were in one line, right now they are kind of not.

and thank you for the great work

[SomeoneIsWorking]

Okay, I got some drops of motivation to update it, also like to play with Copilot Edits.

[SomeoneIsWorking]

Rebased

[RickAndTired]

Is there a way to have the github-actions bot to create another updated appimage?
I'd love to try this feature

Also will this have hotkeys for all players or just 1 and 2?

[GreemDev]

Is there a way to have the github-actions bot to create another updated appimage? I'd love to try this feature

Also will this have hotkeys for all players or just 1 and 2?

Someone has to fix the merge conflicts this has before the appimage can be compiled again.

[SomeoneIsWorking]

Also will this have hotkeys for all players or just 1 and 2?

You can add remove with "Add" "Remove", up to 8 players

Someone has to fix the merge conflicts this has before the appimage can be compiled again.

I'll rebase again soon(tm)

[SomeoneIsWorking]

I rebased it and ran the app, tested around the hotkey settings.
I don't know if the keys still work in game but no reason they shouldn't because the hard part was getting the menu working again.

[RickAndTired]

Pressing a hotkey to cycle controllers in game crashes Ryujinx

Ryujinx_1.2.0+9a7f560_2025-02-07_18-37-03 F1.log

[SomeoneIsWorking]

Pressing a hotkey to cycle controllers in game crashes Ryujinx

Sorry, I'll try to replicate.
Just that the stack trace in the log makes no sense.

InputViewModel.cs:line 903

This line is empty

InputViewModel.cs:line 466

This line is ending brace
I tried subtracting 7 from both because in that way the stack trace makes some sense.
Then it would end up a null error here which I didn't write but nvm that

_mainWindow.InputManager.KeyboardDriver.GamepadsIds

Then it's weird and it looks like you have no gamepads attached. I never tested that case.

Edit: I tried without a controller, it doesn't crash for me.

[RickAndTired]

I tried the linux non appimage version
Same crashes

I tried with both a controller plugged in and also without a controller plugged in
Tried multiple games
Hotkey crashes on players 1-8, but not 9+
Not sure it matters, but looks like there is no limit on adding players (got to 200)

Ryujinx_1.2.0+9a7f560_2025-02-13_00-33-44 NA1.log

[SomeoneIsWorking]

@RickAndTired I'm very sorry, I'll try to debug on a linux if I can, I only debugged this version on macOS.
I also debugged (and regularly use) the previous version from the original repo on Windows.

[RickAndTired]

No worries, let me know if there's anything I can try to do to help.