ecdsa: provide a SigningKey::try_from_rng #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2025
baloo
force-pushed
the
baloo/ecdsa/signing-key-try-from-rng
branch
from
d020834 to
7c22f3e
Compare
tarcieri
pushed a commit
to RustCrypto/traits
that referenced
this pull request
Mar 4, 2025
Depends: - zkcrypto/ff#126 - zkcrypto/ff#127 This is to provide an `ecdsa::SigningKey::try_from_rng` API (RustCrypto/signatures#915)
baloo
force-pushed
the
baloo/ecdsa/signing-key-try-from-rng
branch
3 times, most recently
from
cd0b87b to
e40d853
Compare
baloo
force-pushed
the
baloo/ecdsa/signing-key-try-from-rng
branch
from
e40d853 to
fe8e486
Compare
|
@baloo rebase? |
|
I think that should merge fine and the failing test should be fixed by #923 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends:
Sizedrequirements on the rng zkcrypto/ff#126