-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Protobuf 4.29.3 #156
base: master
Are you sure you want to change the base?
Conversation
Update the protobuf library and protoc to 4.29.3. Update the protobuf build plugins to their most recent versions.
Change the GeoJSON protobuf definition to use proto3 syntax instead of proto2. The only change is the removal of the required flag as it isn't available or needed in proto3.
As of December 2024, the ubuntu-latest GitHub runner no longer contains SBT, it has to be installed manually.
I updated the pull request to install SBT in both the pull request and release actions. It looks like it was dropped from the ubuntu-latest runner as of December last year. |
Here's hoping that changing the |
I'm not sure how to best get the tests to run, maybe split it into two pull requests. The way |
Yeah, I'm not even sure why the tests are failing now. The only thing that's changed for the I generally agree with the idea of trying to make this PR smaller and see if there's some way to make the tests pass while still upgrading the protobuf dependency in the I'm also not sure why we had to switch to |
I've done some testing, and it seems we can fix the tests failing by keeping the @tredpath could you please give it a try? For some reason I couldn't push to your branch myself. |
@@ -44,7 +44,7 @@ lazy val core = (project in file("core")) | |||
"com.novocode" % "junit-interface" % "0.11" % Test | |||
exclude ("junit", "junit-dep"), | |||
"org.slf4j" % "slf4j-api" % "1.7.30", | |||
"net.iakovlev" % "geojson-proto" % "1.1.5" | |||
"net.iakovlev" % "geojson-proto" % "1.1.6-SNAPSHOT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 1.1.5
, not 1.1.6-SNAPSHOT
. My bad, I was resolving conflicts with master
and typed the wrong value.
Update the protobuf library and protoc to 4.29.3 for #136. Updated sbt-protoc to 1.0.7 and compilerplugin to 0.11.17.
I updated the proto file in geojson-proto to use proto3 syntax. The changes were minimal, only the
required
flag had to be dropped since it isn't needed anymore.All tests passed with the updates but I had to modify the build script locally to get the updated geojson-proto library to be used by the core library.

jackson-core, commons-compress, and zstd-jni can be updated without breaking anything internal to this library but I didn't include them as part of this pull request.