-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] LiveChat switch department not working #11011
[FIX] LiveChat switch department not working #11011
Conversation
…he data was not being updated in the visitor collection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@renatobecker the code looks good but I found a weird behavior:
at the first change, we can se the both options... and the popout doesnt close after the change...
and just a thought but if you already started a chat and changed the department I dont think we should wait for another message to call for a new attendant
Related to your first question, that behaviour has been fixed here:https://github.com/RocketChat/Rocket.Chat/pull/10695/files#diff-e531651dd1b362372762eb86f21419f0R76 About the second question, I changed the method called in the Livechat widget. I saw that when an agent was calling the switch department on their side, the behaviour of the process was different from when it was called by Livechat's side, but I do not know the reason for that, so I unified the method called in both sides. Now, when a visitor tries to switch departments, an agent is automatically assigned to the chat (by using I'll be waiting for your review. |
…:RocketChat/Rocket.Chat into fix-changing-livechat-visitor-department
# Conflicts: # packages/rocketchat-livechat/.app/client/views/livechatWindow.js # packages/rocketchat-livechat/.app/client/views/switchDepartment.js
Closes #7397
When a livechat visitor attempted to change the current department, they were staying in the same department.
This was happening because the new department data was not being updated in the visitor collection.