Update Param.js to intuitively request JSON data #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you receive a parameter with get, the data will be received as a number 0, but if you try to modify it with set, you need to JSON.stringify the value again. For example, setting it as {name:"intParam",value:0} will not work, but setting it as {name:"intParam",value:`\"0\"`} will work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public API Changes
There is an inconvenience of having to do JSON.stringify again when setting parameters.
Description
If you receive a parameter with get, the data will be received as a number 0, but if you try to modify it with set, you need to JSON.stringify the value again. For example, setting it as {name:"intParam",value:0} will not work, but setting it as {name:"intParam",value:
\"0\"} will work.#237
It's not the same problem, but it's a similar problem.