Use the retain_mut external library #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 20, 2021
89: Improve unions between arrays r=Kerollmops a=Kerollmops I found out that merging two arrays was quite slow while benchmarking our new search engine. Doing unions of array containers needed improvement. I reworked the algorithm to make it easier to read and removed the inserts triggering a lot of useless memory copy, and made it write into a new allocation. I found out that CRoaring (which is the roaring implementation in c) [was doing a lot SIMD based things to do fast array unions](https://github.com/RoaringBitmap/CRoaring/blob/63a54b15df3bc8fad77a9cc26fbc2dcce5f8da23/src/array_util.c#L1894-L1915), I did not implement them because it would take me a lot of time and that I would prefer using the, soon to be released, [stdsimd library](https://github.com/rust-lang/stdsimd). 90: Use the retain_mut external library r=Kerollmops a=Kerollmops Related to #87 but do not fix it yet. Thanks to @upsuper and its [retain_mut library](https://docs.rs/retain_mut), we can remove our internal copy of the [std `retain` function](https://doc.rust-lang.org/std/vec/struct.Vec.html#method.retain) and let it be maintained externally (until `retain_mut` is merged into the std). Co-authored-by: Clément Renault <clement@meilisearch.com>
|
Build failed (retrying...): |
bors bot
added a commit
that referenced
this pull request
Feb 20, 2021
90: Use the retain_mut external library r=Kerollmops a=Kerollmops Related to #87 but do not fix it yet. Thanks to @upsuper and its [retain_mut library](https://docs.rs/retain_mut), we can remove our internal copy of the [std `retain` function](https://doc.rust-lang.org/std/vec/struct.Vec.html#method.retain) and let it be maintained externally (until `retain_mut` is merged into the std). Co-authored-by: Clément Renault <clement@meilisearch.com>
|
Canceled. |
Kerollmops
force-pushed
the
external-retain-mut
branch
from
8721e61 to
1a1ea62
Compare
|
bors r+ |
|
Build succeeded: |
not-jan
pushed a commit
to not-jan/roaring-rs
that referenced
this pull request
Aug 31, 2022
89: Improve unions between arrays r=Kerollmops a=Kerollmops I found out that merging two arrays was quite slow while benchmarking our new search engine. Doing unions of array containers needed improvement. I reworked the algorithm to make it easier to read and removed the inserts triggering a lot of useless memory copy, and made it write into a new allocation. I found out that CRoaring (which is the roaring implementation in c) [was doing a lot SIMD based things to do fast array unions](https://github.com/RoaringBitmap/CRoaring/blob/63a54b15df3bc8fad77a9cc26fbc2dcce5f8da23/src/array_util.c#L1894-L1915), I did not implement them because it would take me a lot of time and that I would prefer using the, soon to be released, [stdsimd library](https://github.com/rust-lang/stdsimd). 90: Use the retain_mut external library r=Kerollmops a=Kerollmops Related to RoaringBitmap#87 but do not fix it yet. Thanks to @upsuper and its [retain_mut library](https://docs.rs/retain_mut), we can remove our internal copy of the [std `retain` function](https://doc.rust-lang.org/std/vec/struct.Vec.html#method.retain) and let it be maintained externally (until `retain_mut` is merged into the std). Co-authored-by: Clément Renault <clement@meilisearch.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #87 but do not fix it yet.
Thanks to @upsuper and its retain_mut library, we can remove our internal copy of the std
retainfunction and let it be maintained externally (untilretain_mutis merged into the std).