Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change span to color input, update tag on change #458

Merged
merged 4 commits into from
Oct 24, 2023
Merged

change span to color input, update tag on change #458

merged 4 commits into from
Oct 24, 2023

Conversation

mdroidian
Copy link
Collaborator

@mdroidian
Copy link
Collaborator Author

ed8baca
If multiple color tags on on a single block, only the replaced one gets appended (the rest are still blank).
This is a better tradeoff than toggleDecorations() and a smaller use case.
We'll cross that bridge when it shows up.

https://www.loom.com/share/e0b6f3a69d774650a09008000a0cc6c5

@mdroidian mdroidian merged commit 63edf81 into main Oct 24, 2023
@mdroidian mdroidian deleted the decorations-add-color-pick branch October 24, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvargas92495 dvargas92495 Awaiting requested review from dvargas92495

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdroidian