Skip to content

HRI | modify min and max audio length #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 4, 2025
Merged

HRI | modify min and max audio length #234

merged 6 commits into from
Apr 4, 2025

Conversation

Oscar-gg
Copy link
Member

@Oscar-gg Oscar-gg commented Apr 4, 2025

No description provided.

@Oscar-gg Oscar-gg marked this pull request as ready for review April 4, 2025 02:57
@Oscar-gg Oscar-gg requested review from a team as code owners April 4, 2025 02:57
GilMM27
GilMM27 approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@GilMM27 GilMM27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, check suggestions

docker/hri/setup.bash
echo "Restarting pulseaudio for user."

systemctl --user restart pulseaudio
# Restart pulseaudio if socket is not present
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

god.

frida_interfaces/hri/srv/STT.srv Outdated
@@ -1,2 +1,2 @@
---
string text_heard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

hri/packages/speech/debug/wav_utils.py Outdated
@@ -0,0 +1,72 @@
import os
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@Oscar-gg Oscar-gg merged commit 27bf983 into main Apr 4, 2025
5 checks passed
@Oscar-gg Oscar-gg deleted the hri-speech-stt branch April 29, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GilMM27 GilMM27 GilMM27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Oscar-gg @GilMM27