Use info plist preprocessor #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for the main UI built with Interface Builder Signed-off-by: Toni Förster <toni.foerster@icloud.com>
This is used for all strings in the .swift files. Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
stonerl
force-pushed
the
use-info-plist-preprocessor
branch
from
6c27260 to
23fdb26
Compare
stonerl
changed the title
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
stonerl
force-pushed
the
use-info-plist-preprocessor
branch
from
23fdb26 to
dcab06a
Compare
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Signed-off-by: Toni Förster <toni.foerster@icloud.com>
Instead of manually modifying the `NSHumanReadableCopyright` key in every Info.plist, we make use of the Info.plist preprocessor. Therefore, the current year has to be changed only in one place. Project Settings -> Build Settings -> Info.plist Preprocessor Definitions Signed-off-by: Toni Förster <toni.foerster@icloud.com>
stonerl
force-pushed
the
use-info-plist-preprocessor
branch
from
dcab06a to
c23d608
Compare
|
Since Info.plists are also translatable now, I need to find a different way to do this. |
stonerl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use Info.plist preprocessor for copyright year
Instead of manually modifying the
NSHumanReadableCopyrightkey in every Info.plist, we make use of the Info.plist preprocessor.Therefore, the current year has to be changed only in one place.
Project Settings -> Build Settings -> Info.plist Preprocessor Definitions
Since this makes changes to
project.pbxprojit requires the following PRs to be merged first to avoid conflicts: