Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to .NET 7 and C# 11 #465

Merged
merged 23 commits into from
Dec 23, 2022
Merged

Upgrade to .NET 7 and C# 11 #465

merged 23 commits into from
Dec 23, 2022

Conversation

RehanSaeed
Copy link
Owner

@RehanSaeed RehanSaeed commented Jul 27, 2022 •
edited
Loading

  • Add .NET 7 target.
  • Drop .NET 5 and 3.1 target.
  • Update build scripts to install .NET 7 and 6 and stop installing 5 and 3.1.
  • Uses C# 11 features resulting in cleaner code. Raw string literals in particular.
  • Added #nullable enable to generated code which is required to enable nullable reference types. I thought we'd already done it but turns out not!
  • Generate simpler code with better performance.
  • Switch dotnet test --logger to use LogFilePrefix.

@RehanSaeed RehanSaeed added enhancement Issues describing an enhancement or pull requests adding an enhancement. major Pull requests requiring a major version update according to semantic versioning. labels Jul 27, 2022
@RehanSaeed RehanSaeed requested a review from Turnerj July 27, 2022 15:32
@github-actions github-actions bot added the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label Jul 27, 2022
RehanSaeed
RehanSaeed commented Jul 27, 2022
View reviewed changes
RehanSaeed
RehanSaeed commented Jul 27, 2022
View reviewed changes
Turnerj
Turnerj requested changes Jul 28, 2022
View reviewed changes
@RehanSaeed RehanSaeed removed the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label Aug 16, 2022
@github-actions github-actions bot added the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label Aug 16, 2022
@RehanSaeed RehanSaeed removed the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label Aug 17, 2022
@github-actions github-actions bot added the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label Aug 17, 2022
Turnerj
Turnerj previously approved these changes Aug 17, 2022
View reviewed changes
@RehanSaeed RehanSaeed removed the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label Sep 23, 2022
@github-actions github-actions bot added the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label Oct 6, 2022
@RehanSaeed RehanSaeed force-pushed the net-7 branch 3 times, most recently from b2e6c3d to 8b9cc3d Compare October 18, 2022 15:19
@RehanSaeed
Copy link
Owner Author

@Turnerj Updated to RTM. Was getting scary looking warnings about 3.1 not being supported and being untested, so I also removed that. Also, upgraded net461 to net462 for the same reason. Finally, made these two additional updates I discovered:

  • Use GlobalPackageReference.
  • Switch dotnet test --logger to use LogFilePrefix.

@Turnerj Turnerj merged commit 5b95f47 into main Dec 23, 2022
@Turnerj Turnerj deleted the net-7 branch December 23, 2022 06:04
@RehanSaeed RehanSaeed removed the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turnerj Turnerj Turnerj left review comments

Assignees
No one assigned
Labels
enhancement Issues describing an enhancement or pull requests adding an enhancement. major Pull requests requiring a major version update according to semantic versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RehanSaeed @Turnerj