Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .editorconfig from 2.1.0 to 3.0.0 #311

Merged
merged 6 commits into from
Aug 12, 2021
Merged

Conversation

RehanSaeed
Copy link
Owner

  • See https://github.com/RehanSaeed/EditorConfig/releases/tag/3.0.0
  • Set <AnalysisMode>AllEnabledByDefault</AnalysisMode>. This actually picked up a couple of small things that I've fixed. Added a bunch of warning suppressions too though. Also added CLSCompliant(true) so our F# folks can also play.
  • In SchemaService.cs if we found a schema type that started with a number e.g. the pending type 3DModel we prefixed it with an underscore. This is not CLSCompliant, so I changed the prefix to the word Type. Happy to pick something better.

@RehanSaeed RehanSaeed requested a review from Turnerj August 10, 2021 15:03
Copy link
Owner Author

@RehanSaeed RehanSaeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a general cleanup of warning suppressions.

Copy link
Collaborator

@Turnerj Turnerj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@RehanSaeed RehanSaeed added maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. patch Pull requests requiring a patch version update according to semantic versioning. labels Aug 12, 2021
@RehanSaeed RehanSaeed merged commit 437512f into main Aug 12, 2021
@RehanSaeed RehanSaeed deleted the update-editorconfig branch August 12, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. patch Pull requests requiring a patch version update according to semantic versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants