Refining and restructuring the test cases #266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ToString
test (avoids issues with JSON property order) however a round trip conversion test (convert to JSON and back to object) still exists for each proving that theToString
method works.MixedTypesTest
has moved to examples folder (mainly because the logic behind it is tested inValuesJsonConverterTest
however seemed worth keeping as an example)SerializationTest
have been moved intoThingTest
withSerializationTest
being deletedSchemaSerializer
instead of directly usingJsonConvert
(this is the ideal way people will serialize our types and is what we directly call inThing.ToString()
)Overall nothing overly major has changed one way or another but it should eliminate the issue in #100 where tests failed due to JSON order while making a few other bits a little clearer.