Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MinVer NuGet package for Versioning NuGet packages #143

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Conversation

RehanSaeed
Copy link
Owner

@RehanSaeed RehanSaeed commented Mar 18, 2020

  • MinVer does versioning using git tags, git height, build number and git commit SHA all combined.
  • Added Directory.Build.props to configure common .csproj properties.
  • Added Directory.Build.targets to configure MinVer.

@RehanSaeed
Copy link
Owner Author

I'm considering going all in with Directory.Build.props and adding another one under the Source directory to configure assembly signing, turning on xml doc generation and configuring source link. Perhaps even another one under Tests to add xunit etc.

@Turnerj
Copy link
Collaborator

Turnerj commented Mar 20, 2020

Looks good to me! Definitely cleans up a lot of double-ups having a global Directory.Build.props.

Regarding having additional ones under tests and source, I guess it depends whether there will be more projects under those folders or whether the idea is to bring all non-specific configuration out of the single .csproj files.

That said, I'd probably still do it because there is still a chance we might have additional projects later on - whether that be we have separate projects for the extended schema.org types and then require splitting the tests into separate projects for each. 🙂

@RehanSaeed
Copy link
Owner Author

Regarding having additional ones under tests and source, I guess it depends whether there will be more projects under those folders or whether the idea is to bring all non-specific configuration out of the single .csproj files.

I guess it doesn't matter in this one. I have other projects where it will. I try to keep them all consistent though.

@RehanSaeed RehanSaeed merged commit 53b18d7 into master Mar 20, 2020
@RehanSaeed RehanSaeed deleted the minver branch March 20, 2020 12:21
@RehanSaeed
Copy link
Owner Author

Turns out you have to add a nasty <Import> if you want to use multiple nested Directory.Build.props files. I'll do it in another PR.

@RehanSaeed RehanSaeed added the maintenance Pull requests that perform maintenance on the project but add no features or bug fixes. label Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Pull requests that perform maintenance on the project but add no features or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants