Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ord_* prefix examples to sub_* #1864

Merged
merged 21 commits into from
May 3, 2024
Merged

Update ord_* prefix examples to sub_* #1864

merged 21 commits into from
May 3, 2024

Conversation

nanobash
Copy link
Contributor

@nanobash nanobash commented Apr 9, 2024 •
edited
Loading

Summary

  • Update ord_cnl_ to sub_cnl_
  • Update ord_itm_ to sub_/ots_
  • Update ord_pau_ to sub_pau_
  • Update ord_rct_ to sub_rct_
  • Update ord_usg_ to sub_usg_
  • Update ord_ to sub_

Links

Preview

Checklist

  • Writing style
  • API design standards

@nanobash nanobash added the Type: Feature New feature label Apr 9, 2024
@nanobash nanobash self-assigned this Apr 9, 2024
@nanobash nanobash changed the title Update ord prefixes to sub Update ord prefixe examples to sub Apr 9, 2024
@nanobash nanobash changed the title Update ord prefixe examples to sub Update ord_* prefix examples to sub_* Apr 9, 2024
@nanobash nanobash marked this pull request as ready for review April 9, 2024 13:10
@nanobash nanobash requested review from a team as code owners April 9, 2024 13:10
jvc9109
jvc9109 previously approved these changes Apr 9, 2024
View reviewed changes
justnero
justnero previously approved these changes Apr 9, 2024
View reviewed changes
adamaltman
adamaltman requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@adamaltman adamaltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems confusing to me.

@nanobash nanobash dismissed stale reviews from justnero and jvc9109 via ba08733 April 9, 2024 19:57
@nanobash
Copy link
Contributor Author

@Rebilly/php please review

1 similar comment
@nanobash
Copy link
Contributor Author

@Rebilly/php please review

@nanobash nanobash requested a review from adamaltman April 16, 2024 07:51
@nanobash nanobash requested a review from creocoder April 22, 2024 11:09
@nanobash
Copy link
Contributor Author

@Rebilly/php please review

@nanobash
Copy link
Contributor Author

nanobash commented May 2, 2024

@Rebilly/php please review

@nanobash nanobash merged commit a715f89 into main May 3, 2024
3 checks passed
@nanobash nanobash deleted the update-ord-prefixes-to-sub branch May 3, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamaltman adamaltman adamaltman approved these changes

@justnero justnero Awaiting requested review from justnero

@jvc9109 jvc9109 Awaiting requested review from jvc9109

@creocoder creocoder Awaiting requested review from creocoder

Assignees

@nanobash nanobash

Labels
Type: Feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nanobash @creocoder @adamaltman @justnero @jvc9109