Lost Subscriptions #2576
Closed
Lost Subscriptions #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where a Subscription is lost from a Scheduler.
| @@ -46,6 +46,7 @@ public void call(final Subscriber<? super T> s) { | |||
| final Worker worker = scheduler.createWorker(); | |||
| s.add(worker); | |||
|
|
|||
| // FIXME should subscription returned be added to the s composite | |||
There was a problem hiding this comment.
L47: the s.add ensures that pending tasks on the worker are cancelled.
|
Looking at #2575 I'd say the change is a no-op on our scheduler implementations because all scheduled tasks are tracked and can be cancelled all at once if the worker is unsubscribed. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After thinking about #2575 I added a note to all the places where a Subscription is lost from a Scheduler.