Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GetOption with GetOption1 #6849

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Replace GetOption with GetOption1 #6849

merged 1 commit into from
Mar 4, 2025

Conversation

aitap
Copy link
Contributor

@aitap aitap commented Mar 4, 2025

As of r87874 we get:

  Found non-API calls to R: ‘LEVELS’, ‘OBJECT’, ‘Rf_GetOption’,
    ‘Rf_isFrame’, ‘SETLENGTH’, ‘SET_GROWABLE_BIT’, ‘SET_TRUELENGTH’,
    ‘TRUELENGTH’

GetOption1() has been available since R-2.13, and GetOption() has been ignoring its second argument for a long time, so there's no portability cost.

See also: #6180

GetOption1() has been available since R-2.13, and GetOption() has been
ignoring its second argument for a long time, so there's no portability
cost.
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (b0a17dd) to head (fe15955).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6849      +/-   ##
==========================================
- Coverage   98.60%   98.59%   -0.02%     
==========================================
  Files          79       79              
  Lines       14657    14661       +4     
==========================================
+ Hits        14453    14455       +2     
- Misses        204      206       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 4, 2025

Comparison Plot

Generated via commit fe15955

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 4 minutes and 28 seconds
Installing different package versions 8 minutes and 23 seconds
Running and plotting the test cases 2 minutes and 31 seconds

@MichaelChirico MichaelChirico merged commit f248d33 into master Mar 4, 2025
9 of 11 checks passed
@MichaelChirico MichaelChirico deleted the GetOption1 branch March 4, 2025 14:23
MichaelChirico pushed a commit that referenced this pull request Mar 10, 2025
GetOption1() has been available since R-2.13, and GetOption() has been
ignoring its second argument for a long time, so there's no portability
cost.
@MichaelChirico MichaelChirico added this to the 1.17.2 milestone Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants