Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export masks for NSE-only constructs ., J, patterns and measure #6125

Merged
merged 34 commits into from
Jun 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
16683b2
masking function
May 6, 2024
06841af
Merge branch 'master' into Masking-functions
Nj221102 May 6, 2024
0003f9a
Update data.table.R
Nj221102 May 9, 2024
f63ae30
Merge branch 'master' into Masking-functions
Nj221102 May 27, 2024
070978c
Merge branch 'master' into Masking-functions
Nj221102 Jun 1, 2024
86ea33c
Removed mask for pattern and measure
Jun 1, 2024
6700f0e
Merge branch 'master' into Masking-functions
Nj221102 Jun 2, 2024
e1772e6
exporting pattern and measure
Jun 3, 2024
3095edd
Merge branch 'master' into Masking-functions
Nj221102 Jun 3, 2024
a1fdd4e
added news entry
Jun 3, 2024
bda02d8
editing news item
Jun 3, 2024
82ca538
updating news
Jun 4, 2024
a971529
updating news item
Jun 7, 2024
fc2459d
updated news item
Jun 8, 2024
4715f4e
Merge branch 'master' into Masking-functions
Nj221102 Jun 8, 2024
8dc023a
Update NEWS.md
Nj221102 Jun 8, 2024
adfac00
Update NEWS.md
Nj221102 Jun 8, 2024
628f4df
Merge branch 'master' into Masking-functions
Nj221102 Jun 13, 2024
5df7403
updating news
Jun 13, 2024
6751a2b
delete comment
Jun 13, 2024
7f1cfed
Merge branch 'master' into Masking-functions
Nj221102 Jun 19, 2024
4058118
updated test and mask for J
Jun 19, 2024
22f9706
improved the error message
Jun 19, 2024
40101d4
updated error messages
Jun 19, 2024
1dc2c2c
improving error message
Jun 19, 2024
3510565
Merge branch 'master' into Masking-functions
Nj221102 Jun 20, 2024
5ebd8b6
Update NEWS.md
Nj221102 Jun 20, 2024
82ca346
Merge branch 'master' into Masking-functions
Nj221102 Jun 20, 2024
1d61cce
small changes
Jun 20, 2024
127b45e
Update vignettes/datatable-importing.Rmd
Nj221102 Jun 20, 2024
90cd873
Update NEWS.md
Nj221102 Jun 20, 2024
87e50e1
grammar
MichaelChirico Jun 20, 2024
80c56eb
updating error message
Jun 20, 2024
ea84607
updating example
Jun 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update data.table.R
  • Loading branch information
Nj221102 authored May 9, 2024

Verified

This commit was signed with the committer’s verified signature.
austinhuang0131 Austin Huang
commit 0003f9a7dddfb31e79d1041dd87b84c5f40b06b0
2 changes: 1 addition & 1 deletion R/data.table.R
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ patterns = function(...) NULL
measure = function(...) NULL
# These are exported to prevent NOTEs from R CMD check, and checkUsage via compiler.
# But also exporting them makes it clear (to users and other packages) that data.table uses these as symbols.
# And NULL makes it clear (to the R's mask check on loading) that they're variables not functions.
# The use of NULL during loading signals to R's mask check that these entities aren't defined with specific behaviors.
# utils::globalVariables(c(".SD",".N")) was tried as well, but exporting seems better.
# So even though .BY doesn't appear in this file, it should still be NULL here and exported because it's
# defined in SDenv and can be used by users.
Loading