Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always set --target when sanitizer is used #17

Merged
merged 1 commit into from
May 1, 2023
Merged

Always set --target when sanitizer is used #17

merged 1 commit into from
May 1, 2023

Conversation

Jules-Bertholet
Copy link
Contributor

This ensures that the sanitizer flag is not passed to build scripts and proc macros.

@Jules-Bertholet
Always set --target when sanitizer is used
a013d42 
This ensures that the sanitizer flag
is not passed to build scripts and proc macros.
@RalfJung
Copy link
Owner

Is it a known issue that -Zsanitizer requires an explicit --target?

@Jules-Bertholet
Copy link
Contributor Author

Yes, it's mentioned here.

@RalfJung
Copy link
Owner

RalfJung commented May 1, 2023

Ah, I found the cargo issue: rust-lang/cargo#3739.

@RalfJung RalfJung merged commit e7f4cc2 into RalfJung:master May 1, 2023
@Jules-Bertholet Jules-Bertholet deleted the sanitizer-target branch May 1, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jules-Bertholet @RalfJung