Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed target global position when using rootOverlay and inner navigator #142

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Conversation

guildem
Copy link
Contributor

@guildem guildem commented Feb 9, 2023

Description

When using an inner navigator or on more complex use cases, there is offset between the tutorial target and the real widget position if using rootOverlay. This PR import the rootOverlay value to use it on the getTargetCurrent function, to use root Overlay context for RendeObject position.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I open this PR to the develop branch.
  • I have added a description of the change under [next] in CHANGELOG.md.
  • I ran flutter format --set-exit-if-changed --dry-run . and has success.

Breaking Change

Does your PR require Flame users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md).
  • No, this is not a breaking change.

@RafaelBarbosatec
Copy link
Owner

LGTM! Thanks so much !

@RafaelBarbosatec RafaelBarbosatec merged commit d56961d into RafaelBarbosatec:develop Feb 12, 2023
@RafaelBarbosatec RafaelBarbosatec mentioned this pull request Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants