Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HWIMO-TEST mocha timeout to 10s. #44

Merged
merged 1 commit into from
Jun 27, 2016
Merged

Update HWIMO-TEST mocha timeout to 10s. #44

merged 1 commit into from
Jun 27, 2016

Conversation

jimturnquist
Copy link
Contributor

This is necessary for some build machines where dependency
loading is too slow to stay under the 2s per test timeout.

@RackHD/corecommitters

This is necessary for some build machines where dependency
loading is too slow to stay under the 2s per test timeout.
@lanchongyizu
Copy link
Member

@jimturnquist Nice work! The same change could be made to package.json.

Besides the following two PRs, you could also pull requests on all other repos such as on-http, on-core and on-tasks, etc.

RackHD/on-taskgraph#132
RackHD/on-dhcp-proxy#47

@benbp
Copy link
Contributor

benbp commented Jun 27, 2016

@lanchongyizu we've resisted actually landing these changes into an area of the code that affects everybody. In this case, the core issue is the build servers that @jimturnquist is using have all code mounted on an NFS share, which is what is causing the latency that leads to timeouts. As far as I know, the HWIMO-TEST script is only being used by that same team, so these changes effectively serve as a workaround local to them, without forcing everybody else to use an unnecessarily large timeout.

👍

@tldavies
Copy link
Contributor

👍

@benbp benbp merged commit ec471bb into RackHD:master Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants