Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched to AsyncKeyedLock library for better performance #106

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Switched to AsyncKeyedLock library for better performance #106

wants to merge 3 commits into from

Conversation

MarkCiliaVincenti
Copy link

No description provided.

@MarkCiliaVincenti
Copy link
Author

@majiccode please let me know

@avmgan
Copy link
Collaborator

avmgan commented Feb 12, 2024

current develop branch merged DXA 2.3 release related changes, it's conflicting your changes.
I think better we can keep AsynKeylockCacheProvider separate class, people can choose which caching machanism they want rather than overriding the exisitng options, if you raise a new PR by keeping the new class, I can review and merge it. if not I can plan to this change sometime later.

@majiccode
Copy link
Contributor

@MarkCiliaVincenti looks good to me :)

@MarkCiliaVincenti
Copy link
Author

@MarkCiliaVincenti looks good to me :)

Check now pls.

@MarkCiliaVincenti
Copy link
Author

@majiccode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkCiliaVincenti @avmgan @majiccode