[AmazonPriceTracker] Minor fix for parser, and new strategy #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request artifacts
|
captn3m0
force-pushed
the
amazon-parse-minor-fix
branch
2 times, most recently
from
312852b to
835d7de
Compare
The GenericParser gets confused because some elements contain the data twice - this puts a forced-two-decimal places limit as a workaround. Add another strategy (which takes precedence) as well
captn3m0
force-pushed
the
amazon-parse-minor-fix
branch
from
835d7de to
be1a7c9
Compare
|
The previews didnt work because of an error in my prtester. This is fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "double" price issue in AmazonPriceTracker. (Noted here by @yamanq)
The GenericParser gets confused because some elements contain the
data twice - this puts a forced-two-decimal places limit as a
workaround.
Add another strategy (which takes precedence) as well