[RedditBridge] Typo and checking subreddit existence #1345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into RedditBridge
Comment on lines
+39
to
+55
| // If in CLI mode with no root certificates defined, skip the url verification | ||
| if(php_sapi_name() !== 'cli' || !empty(ini_get('curl.cainfo'))) { | ||
| // We must test if the subreddit exists before gathering the content | ||
| $ch = curl_init(); | ||
| curl_setopt($ch, CURLOPT_URL, $url); | ||
| curl_setopt($ch, CURLOPT_USERAGENT, ini_get('user_agent')); | ||
| curl_setopt($ch, CURLOPT_RETURNTRANSFER, true); | ||
| curl_exec($ch); | ||
| $httpcode = curl_getinfo($ch, CURLINFO_HTTP_CODE); | ||
| curl_close($ch); | ||
|
|
||
| if($httpcode !== 403 && $httpcode !== 302) { | ||
| $this->collectExpandableDatas($url); | ||
| } | ||
| } else { | ||
| $this->collectExpandableDatas($url); | ||
| } |
There was a problem hiding this comment.
Referring to your last comment: #1213 (comment)
RSS-Bridge is supposed to return an error if the resource doesn't exist. This is the intended way to let users know that they provided incorrect input data. In either case, a bridge should never circumvent the API. If you think it doesn't work as intended, don't hesitate to open an issue for further discussion.
With the queriedContext fix from above, my machine correctly responds with
Reddit Bridge was unable to receive or process the
remote website's content!
Error message: `The requested resource cannot be found!
Please make sure your input parameters are correct!
cUrl error: (0)
PHP error: `
Query string: `action=display&bridge=Reddit&context=single&r=react&format=Atom`
Version: `git.master.3bc8c94`
Am I missing something?
|
Closing because #1383 brought in the necessary fix for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a small typo (
$this->queriedcontextinstead of$this->queriedContext)I also add a test to verify the HTTP Response from Reddit. This test will prevent the invalidation of the whole feed if any of the subreddit doesn't exists