[README]Add Heroku one click deploy button

[squirrel532]

Heroku provides free plan for anyone, this commit makes it more easily to deploy a rss-bridge instance.

[ghost]

Are you completely sure it is free and stays alive ? Last time I checked I was able to setup an environment but it was only available for a certain period. Maybe I did something wrong. Will check it again! https://RssBridge.TomDings.com/

I am using my own multi-homed release. Hosted from - currently - 17 locations, continuously updated, many additions - other bridges too - and some awesome tools which I needed. Nice feature ... I can request as many feed updates as I want and all systems keep on running stable.

Some details : https://www.facebook.com/Social.Rss.Bridges/

• My service is public available and it is mentioned on the Rss-Bridge public services too. Just in case anyone likes to use it too.

[ghost]

Created a new account and got this notification :
Free trial until July 2nd

May I ask what I am doing wrong ?

[logmanoriginal]

Thanks for the PR!
Heroku is a new one for me, looks very promising.

That said, find below one point for consideration.
Please also check the two files composer.json and composer.lock, they shouldn't be part of this commit as only the app.json file is required according to https://devcenter.heroku.com/articles/heroku-button

[logmanoriginal]

Are you completely sure it is free and stays alive ?

That is not a problem. We don't rely on these services, so adding a button is not a problem. If these services disappear we'll simply remove the deploy button. Of course, if they don't provide a free plan it's up to everyone to pay (or use any of the other deploy options).

You can find their pricing plans here. https://www.heroku.com/pricing

[squirrel532]

Please also check the two files composer.json and composer.lock, they shouldn't be part of this commit as only the app.json file is required according to https://devcenter.heroku.com/articles/heroku-button

Heroku deploy button requires app.json, and Heroku use composer.json, composer.lock to handle dependencies of a PHP project. Without composer.json, I even can't execute it manually.

[logmanoriginal]

Heroku deploy button requires app.json, and Heroku use composer.json, composer.lock to handle dependencies of a PHP project. Without composer.json, I even can't execute it manually.

I see. That is unfortunate. Is it maybe possible to move all the files to a subfolder (i.e. .heroku and .composer)?
Or if that isn't feasible, can the app.json be renamed to something like heroku-app.json?

That way it's easier to tell what the file belongs to.

[squirrel532]

Created a new account and got this notification :
Free trial until July 2nd

May I ask what I am doing wrong ?

You can try clicking that button from my forked repo azdkj532/rss-bridge, because that link will deploy repo you clicked.

[squirrel532]

Or if that isn't feasible, can the app.json be renamed to something like heroku-app.json?

I'll have a look on this.

[squirrel532]

https://devcenter.heroku.com/articles/deploying-php#overview
Document says that composer.json must stay in root dir.

[logmanoriginal]

https://devcenter.heroku.com/articles/deploying-php#overview
Document says that composer.json must stay in root dir.

I thought so. No problem though, since the filename is distinguishable.

[squirrel532]

https://devcenter.heroku.com/articles/heroku-button#requirements
Unfortunately, app.json must be in root dir, too.

[logmanoriginal]

https://devcenter.heroku.com/articles/heroku-button#requirements
Unfortunately, app.json must be in root dir, too.

That is very unfortunate. They should really provide some options for this, as app.json is not very helpful if it's a proprietary format. Anyway, we need a way to identify the file for future maintenance.

Can we add custom elements to app.json?
For example: "service": "Heroku"

[squirrel532]

It works! Demo Site

[logmanoriginal]

It works! Demo Site

That is very good news, thanks for taking care of it 👍

One more question, since we have to keep the composer files. Should they require additional extensions to fully support all the requirements?

Right now there is only mbstring and sqlite3.

Found some more details about what I mean. https://getcomposer.org/doc/01-basic-usage.md#platform-packages

[squirrel532]

Some extensions are enabled by default, it's ok to add them explicitly. Thanks.

[logmanoriginal]

Thanks for the updates. I tested it on my machine and found two additional points.

1. This project still supports PHP 5.6, so the required version should be changed from ^7.1 to >=5.6

2. The lock file is not up-to-date

[logmanoriginal]

This should do it. Thanks again 🥇