cpu/stm32: optimized definition of CPUID_ADDR #7731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haukepetersen
added
Platform: ARM
50 tasks
vincent-d
approved these changes
Oct 13, 2017
cpu/stm32f7/include/periph_cpu.h
Outdated
| * @name Starting address of the CPU ID | ||
| */ | ||
| #ifdef CPU_MODEL_STM32F722ZE | ||
| #define CPUID_ADDR (0x1ff07A10) |
There was a problem hiding this comment.
Minor nit: everything is lowercase except the A
There was a problem hiding this comment.
copy pasta, will fix
kYc0o
approved these changes
Oct 13, 2017
haukepetersen
force-pushed
the
opt_stm32_cpuid
branch
from
8fda1b1 to
625cba4
Compare
|
fixed upper case issue and squashed it right in. |
|
I tested successfully in the boards I have but since the change touches quite a lot of boards I'm unsure... @haukepetersen if you think everything should work you're free to push the green button ;-) |
haukepetersen
force-pushed
the
opt_stm32_cpuid
branch
from
625cba4 to
39f715e
Compare
haukepetersen
force-pushed
the
opt_stm32_cpuid
branch
from
39f715e to
5a35517
Compare
|
Did a careful review once more and tested all STMs that I have laying around here: now I am confident that this PR does not brake anything -> go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a lot of redundant information, as (with very few exceptions) the members of the stm32 families use the same CPUID offset address. So no need to specify if for each CPU_MODEL.
Further: removing this value from the linker scripts takes away a difference between stm32 and other cortex CPU families, so we can actually used shared linkerscripts (see #7729).