Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: introduce pkg-prepare target #7266

Merged
merged 3 commits into from
Aug 29, 2017
Merged

Conversation

kaspar030
Copy link
Contributor

@kaspar030 kaspar030 commented Jun 28, 2017

Previously, packages were downloaded/patched/compiled each in one go, in alphabetical order. This broke at least nrf52dk (see #6022).

This PR adds a "pkg-prepare" target, which all package *.a depend on, which in turn all depends on. The result is that before compiling anything, all packages get downloaded, extracted and patched.

Fixes #6022.

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: build system Area: Build system Area: pkg Area: External package ports labels Jun 28, 2017
@kaspar030 kaspar030 added this to the Release 2017.07 milestone Jun 28, 2017
@kaspar030 kaspar030 requested a review from miri64 June 28, 2017 12:42
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jun 28, 2017
Copy link
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one. Works as expected on the nrf52. ACK

@haukepetersen
Copy link
Contributor

All green -> go

@haukepetersen haukepetersen merged commit 29ee609 into RIOT-OS:master Aug 29, 2017
@haukepetersen haukepetersen deleted the pkg-prepare branch August 29, 2017 15:53
@haukepetersen haukepetersen restored the pkg-prepare branch August 29, 2017 15:53
@kaspar030 kaspar030 deleted the pkg-prepare branch August 29, 2017 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants