-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mulle: Use hardware CS for on-board LIS3DH #6572
Merged
haukepetersen
merged 2 commits into
RIOT-OS:master
from
jnohlgard:pr/mulle-lis3dh-settings
Aug 24, 2017
Merged
mulle: Use hardware CS for on-board LIS3DH #6572
haukepetersen
merged 2 commits into
RIOT-OS:master
from
jnohlgard:pr/mulle-lis3dh-settings
Aug 24, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
5202d92
to
8614dbf
Compare
I guess we missed this one because it seems to be mergeable. Anyone for an ACK ? |
@kYc0o do you mind taking a look at this PR? It should be enough to see that the accelerometer works with SAUL in the default example. |
haukepetersen
approved these changes
Aug 24, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works as expected -> ACK
Also all green -> go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: drivers
Area: Device drivers
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: ARM
Platform: This PR/issue effects ARM-based platforms
Type: cleanup
The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the board configuration to use hardware CS for the on-board LIS3DH accelerometer and changes the lis3dh driver to use SPI mode 3, which is what the LIS3DH data sheet specifies.