Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mulle: Use hardware CS for on-board LIS3DH #6572

Merged
merged 2 commits into from
Aug 24, 2017

Conversation

jnohlgard
Copy link
Member

This PR changes the board configuration to use hardware CS for the on-board LIS3DH accelerometer and changes the lis3dh driver to use SPI mode 3, which is what the LIS3DH data sheet specifies.

@jnohlgard jnohlgard added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers labels Feb 7, 2017
@jnohlgard jnohlgard added this to the Release 2017.04 milestone Feb 7, 2017
@aabadie
Copy link
Contributor

aabadie commented Jun 20, 2017

I guess we missed this one because it seems to be mergeable. Anyone for an ACK ?

@jnohlgard jnohlgard assigned kYc0o and unassigned haukepetersen Aug 3, 2017
@jnohlgard jnohlgard added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 3, 2017
@jnohlgard
Copy link
Member Author

@kYc0o do you mind taking a look at this PR? It should be enough to see that the accelerometer works with SAUL in the default example.

Copy link
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected -> ACK

@haukepetersen
Copy link
Contributor

Also all green -> go

@haukepetersen haukepetersen merged commit 7ea1e9d into RIOT-OS:master Aug 24, 2017
@jnohlgard jnohlgard deleted the pr/mulle-lis3dh-settings branch August 25, 2017 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants