Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

at86rf2xx: different types have RSSI base values #6369

Merged
merged 1 commit into from
Jan 19, 2017
Merged

at86rf2xx: different types have RSSI base values #6369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion drivers/include/at86rf2xx.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,17 @@ extern "C" {
/**
* @brief Base (minimal) RSSI value in dBm
*/
#define RSSI_BASE_VAL (-91)
#if MODULE_AT86RF233
# define RSSI_BASE_VAL (-94)
#elif MODULE_AT86RF212B
/**
* @note for the default settings in RIOT for the at86rf212b,
* for other seetings this value may change.
*/
# define RSSI_BASE_VAL (-98)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo "fur" and unintended tap I guess

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo, but which tap are you referring to?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't a tap but spaces between "'#" and "define".

#else
# define RSSI_BASE_VAL (-91)
#endif

/**
* @brief Flags for device internal states (see datasheet)
Expand Down