Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: use proper inttype for runtime, use import instead of declaration, rename to runtime_ticks #334

Merged
merged 2 commits into from
Nov 19, 2013

Conversation

LudwigKnuepfer
Copy link
Member

define runtime long as hwtimer_now() uses long
import hwtimer.h instead of declaring hwtimer_now()
rename runtime to reflect the unit of measurement

define runtime long as hwtimer_now() uses long
import hwtimer.h instead of declaring hwtimer_now()
@OlegHahm
Copy link
Member

ACK

@@ -90,7 +90,7 @@
unsigned int laststart; /*< Time stamp of the last time this thread was
scheduled to run */
unsigned int schedules; /*< How often the thread was scheduled to run */
unsigned int runtime; /*< The total runtime of this thread */
unsigned long runtime; /*< The total runtime of this thread */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioning the unit would be useful. :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the unit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean like runtime_ticks?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, plus in 5 words, what a runtime_tick is....

@LudwigKnuepfer
Copy link
Member Author

@Kijewski @mehlis ACK?

@mehlis
Copy link
Contributor

mehlis commented Nov 18, 2013

without testing -> ACK

I can perform a runtime test this evening.

@OlegHahm
Copy link
Member

2013-11-19 17:46:40,490 - INFO #    pid | name                 | state    Q | pri | stack ( used) location   | runtime | switches 
2013-11-19 17:46:40,498 - INFO #      0 | idle                 | pending  Q |  31 |   160 (  152) 0x40000048 | 65.857% |        47
2013-11-19 17:46:40,507 - INFO #      1 | main                 | running  Q |  15 |  4608 ( 2248) 0x400000e8 | 33.769% |       407
2013-11-19 17:46:40,516 - INFO #      2 | uart0                | bl rx    _ |  14 |   324 (  288) 0x40001764 |  0.055% |       627
2013-11-19 17:46:40,524 - INFO #      3 | udp_packet_handler   | bl rx    _ |  15 |   512 (  512) 0x4000c191 |  0.000% |         1
2013-11-19 17:46:40,533 - INFO #      4 | tcp_packet_handler   | bl rx    _ |  15 |   512 (  512) 0x4000bf91 |  0.000% |         1
2013-11-19 17:46:40,541 - INFO #      5 | radio                | bl rx    _ |  13 |   512 (  236) 0x40009a18 |  0.000% |         1
2013-11-19 17:46:40,550 - INFO #      6 | Transceiver          | bl rx    _ |  12 |  4096 ( 1784) 0x40007b24 |  0.238% |         9
2013-11-19 17:46:40,558 - INFO #      7 | ip_process           | bl rx    _ |  14 |  3072 (  324) 0x4000a0a0 |  0.000% |         2
2013-11-19 17:46:40,567 - INFO #      8 | lowpan_context_rem   | sleeping _ |  16 |   512 (  300) 0x4000b41c |  0.000% |         2
2013-11-19 17:46:40,575 - INFO #      9 | lowpan_transfer      | sleeping _ |  14 |   512 (  196) 0x4000acb0 |  0.000% |         1
2013-11-19 17:46:40,584 - INFO #     10 | send_tcp_thread      | bl rx    _ |  15 |  4500 ( 4500) 0x400040a6 |  0.000% |         1
2013-11-19 17:46:40,589 - INFO #        | SUM                  |            |     | 19320

looks fine. Merge

OlegHahm added a commit that referenced this pull request Nov 19, 2013
scheduler: use proper inttype for runtime, use import instead of declaration, rename to runtime_ticks
@OlegHahm OlegHahm merged commit 67d975a into RIOT-OS:master Nov 19, 2013
@LudwigKnuepfer LudwigKnuepfer deleted the scheduler_clean_fix branch November 19, 2013 16:51
thomaseichinger pushed a commit to thomaseichinger/RIOT that referenced this pull request Dec 9, 2013
scheduler: use proper inttype for runtime, use import instead of declaration, rename to runtime_ticks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants