-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scheduler: use proper inttype for runtime, use import instead of declaration, rename to runtime_ticks #334
Conversation
define runtime long as hwtimer_now() uses long import hwtimer.h instead of declaring hwtimer_now()
ACK |
@@ -90,7 +90,7 @@ | |||
unsigned int laststart; /*< Time stamp of the last time this thread was | |||
scheduled to run */ | |||
unsigned int schedules; /*< How often the thread was scheduled to run */ | |||
unsigned int runtime; /*< The total runtime of this thread */ | |||
unsigned long runtime; /*< The total runtime of this thread */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioning the unit would be useful. :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for the unit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean like runtime_ticks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, plus in 5 words, what a runtime_tick is....
without testing -> ACK I can perform a runtime test this evening. |
looks fine. Merge |
scheduler: use proper inttype for runtime, use import instead of declaration, rename to runtime_ticks
scheduler: use proper inttype for runtime, use import instead of declaration, rename to runtime_ticks
define runtime long as hwtimer_now() uses long
import hwtimer.h instead of declaring hwtimer_now()
rename runtime to reflect the unit of measurement