kinetis: Add LPM implementation #2605

jnohlgard · 2015-03-16T08:43:09Z

~~This PR depends on the atomic counters in #2321~~ - merged

Add support for Kinetis power modes: WAIT, STOP, VLPS, LLS.

Also included is a refactoring of the UART driver to allow low power modes while still being responsive to RX bytes and prevent deep sleep modes when the last TX byte has not yet been transmitted on the line. This requires using TX interrupts to detect when a transmission is done.

The deepest possible hardware sleep mode will be dynamically selected when lpm_set(LPM_IDLE).

Missing power modes:

VLLSx (requires substantial work in the startup code)
VLPW, VLPR (needs some updates in the bus drivers to reconfigure bus speeds for low power mode)

Tested on:

k60/mulle

jnohlgard · 2015-03-28T07:19:31Z

Added a small bug fix for setting up the NVIC when initializing blocking mode.

jnohlgard · 2015-05-08T19:27:17Z

Rebased since #2321 was merged.

jnohlgard · 2015-05-18T05:28:18Z

ping @jfischer-phytec-iot

Ready for review

jfischer-no · 2015-05-19T17:25:43Z

I will adapt and test it on pba-d-01-kw2x.

jnohlgard · 2015-05-20T18:59:21Z

I should add a DSB instruction before the WFI.

jnohlgard · 2015-05-22T07:25:11Z

rebased, added DSB before WFI

jfischer-no · 2015-05-27T13:23:59Z

@gebart a0699b0 makes UART broken on the kw2x, the interrupts (from the uart) will be no longer triggered. If I comment out jnohlgard@a0699b0#diff-0f87a847fbd98c6b77134bcd0c723ee5R366 , uart interrupts works again. I still have not figured out why.

jnohlgard · 2015-06-25T06:42:13Z

@jfischer-phytec-iot can you try again with the newly rebased version?
I fixed a bug where the system would deadlock if printf was called with interrupts disabled.

Did UART TX still work when you commented out the line you mentioned?

jfischer-no · 2015-06-25T06:53:13Z

@gebart Well, I will try during the day.

jfischer-no · 2015-06-25T21:24:04Z

@gebart I have tested fdaf098 on kw2x and k64f, uart works 🎆 . I will test LPM tomorrow.

jfischer-no · 2015-06-25T22:28:08Z

cpu/kinetis_common/include/kinetis_lpm.h

+    KINETIS_LPM_EDGE_RISING = 0b01,
+    /** Wake on falling edge */
+    KINETIS_LPM_EDGE_FALLING = 0b10,
+    /** Wake on any logic change */


over-commented, the identifiers are self-explanatory

jfischer-no · 2015-07-09T14:32:22Z

@gebart I've implemented a lpm command (lpm [sleep, powerdown, off]) for the shell and now I see that without proper power manager, we will not get anywhere.

jfischer-no · 2015-07-09T16:31:54Z

@gebart
https://github.com/jfischer-phytec-iot/RIOT/commits/gebart%40pr/kinetis-lpm
https://github.com/jfischer-phytec-iot/RIOT/commit/3034040ca40c0e4662e2ff88423b555fe0d59e59
look at it when you have time.

jnohlgard · 2015-07-09T19:54:08Z

I managed to get everything down to 100 µA in VLPS, and around 50 µA in LLS, using the hello-world example (so no processes are running except for the LPTMR overflow ISR handler every 2 seconds). To get low power I had to add initialization code for some of the on-board devices (flash memory and radio transceiver) to trigger low power modes during boot. It does not seem to affect the device initialization performed by the at86rf231 driver.

@jfischer-phytec-iot Do you have any opinions on this method? Hard coding small init sequences for on board devices inside the board_init function, even when the actual driver for the device has not been enabled in the build.

@jfischer-phytec-iot I looked at your suggestion, it was something like that I had in mind when I opened #2927. I like it, do you think we should merge this first and then do a separate PR for the power manager, or do the power manager first, or combine the two in one PR? I think this one (#2605) is pretty close to being mergable, but we will still have to rewrite it when we introduce the power manager.

- Use IRQ for normal TX. - Inhibit low power modes while transmitting. - Inhibit low power modes while receiving. - Disable LLS mode if receiving callback is set.

…ode.

…tion

zhuoshuguo · 2016-01-23T10:14:37Z

@gebart Ping. A kind reminder for rebase.

jnohlgard · 2016-07-12T08:25:07Z

on hold until xtimer catches up

miri64 · 2017-01-13T16:02:03Z

With #6160 merged: Is this still relevant?

smlng · 2017-03-06T08:45:36Z

lpm was removed in #6160, as @miri64 already said. Hence, +1 for closing this one

PeterKietzmann · 2017-03-28T14:28:43Z

Guess it's outdated. Will close with memo label set. @gebart please reopen if I'm mistaken.

maribu · 2020-06-04T09:06:39Z

This PR is still referred to from the mulle boards doc. Can someone familiar with the board update the doc?

jnohlgard added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Mar 16, 2015

jfischer-no self-assigned this Mar 16, 2015

jnohlgard mentioned this pull request Mar 16, 2015

cpu: RIOT port for Freescale Kinetis CPUs #2188

Closed

45 tasks

jfischer-no added the State: waiting for other PR State: The PR requires another PR to be merged first label Mar 16, 2015

jnohlgard force-pushed the pr/kinetis-lpm branch from 5511dfc to abbc9e0 Compare March 16, 2015 12:08

jnohlgard mentioned this pull request Mar 20, 2015

Add support for Kinetis K60 CPUs and Eistec Mulle IoT board #2282

Merged

jnohlgard added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 28, 2015

OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01

jnohlgard mentioned this pull request Apr 28, 2015

core: Atomic counters #2321

Merged

jnohlgard mentioned this pull request May 7, 2015

core: Automatically select the lowest possible LPM mode #2927

Closed

jnohlgard force-pushed the pr/kinetis-lpm branch from 9ade5eb to 8d795c6 Compare May 8, 2015 19:26

jnohlgard removed the State: waiting for other PR State: The PR requires another PR to be merged first label May 8, 2015

jnohlgard force-pushed the pr/kinetis-lpm branch from 8d795c6 to 6481aea Compare May 18, 2015 05:29

jnohlgard force-pushed the pr/kinetis-lpm branch from 6481aea to 693f583 Compare May 22, 2015 07:24

jnohlgard force-pushed the pr/kinetis-lpm branch from 693f583 to fdaf098 Compare June 25, 2015 06:38

jfischer-no reviewed Jun 25, 2015
View reviewed changes

jnohlgard force-pushed the pr/kinetis-lpm branch from caeb6e0 to 90f90f8 Compare July 9, 2015 12:46

jonas-rem mentioned this pull request Jul 9, 2015

802.15.4(e) MAC-Layer Task Force #3039

Closed

3 tasks

jnohlgard added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jul 9, 2015

Joakim Gebart added 11 commits July 20, 2015 12:45

kinetis: Add LPM implementation

4120f22

kinetis: UART refactor

4bba8c0

- Use IRQ for normal TX. - Inhibit low power modes while transmitting. - Inhibit low power modes while receiving. - Disable LLS mode if receiving callback is set.

kinetis: UART enable NVIC vector for TX interrupts even in blocking m…

d25a626

…ode.

k60: Remove stub LPM implementation

7f56b08

squash kinetis: Add DSB before WFI instruction to ensure write comple…

61e09f1

…tion

squash BITBAND_REG32

55e1e4e

squash UART busy wait if interrupts are disabled

8c71f39

kinetis: rtt disable interrupt and clear pending when initializing.

189e8d7

squash kinetis: LLWU updates after comments

32c607a

squash Add LPM tracing via GPIO, improve startup on Mulle

8bc7939

squash small fixes

adf1556

jnohlgard force-pushed the pr/kinetis-lpm branch from 2fb2abe to adf1556 Compare July 20, 2015 10:46

OlegHahm added the Area: pm Area: (Low) power management label Dec 13, 2015

miri64 modified the milestone: Release 2016.07 Mar 29, 2016

jnohlgard removed this from the Release 2016.07 milestone Jul 12, 2016

PeterKietzmann added the State: archived State: The PR has been archived for possible future re-adaptation label Mar 28, 2017

PeterKietzmann closed this Mar 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kinetis: Add LPM implementation #2605

kinetis: Add LPM implementation #2605

jnohlgard commented Mar 16, 2015

jnohlgard commented Mar 28, 2015

jnohlgard commented May 8, 2015

jnohlgard commented May 18, 2015

jfischer-no commented May 19, 2015

jnohlgard commented May 20, 2015

jnohlgard commented May 22, 2015

jfischer-no commented May 27, 2015

jnohlgard commented Jun 25, 2015

jfischer-no commented Jun 25, 2015

jfischer-no commented Jun 25, 2015

jfischer-no Jun 25, 2015

jfischer-no commented Jul 9, 2015

jfischer-no commented Jul 9, 2015

jnohlgard commented Jul 9, 2015

zhuoshuguo commented Jan 23, 2016

jnohlgard commented Jul 12, 2016

miri64 commented Jan 13, 2017

smlng commented Mar 6, 2017

PeterKietzmann commented Mar 28, 2017

maribu commented Jun 4, 2020

kinetis: Add LPM implementation #2605

kinetis: Add LPM implementation #2605

Conversation

jnohlgard commented Mar 16, 2015

jnohlgard commented Mar 28, 2015

jnohlgard commented May 8, 2015

jnohlgard commented May 18, 2015

jfischer-no commented May 19, 2015

jnohlgard commented May 20, 2015

jnohlgard commented May 22, 2015

jfischer-no commented May 27, 2015

jnohlgard commented Jun 25, 2015

jfischer-no commented Jun 25, 2015

jfischer-no commented Jun 25, 2015

jfischer-no Jun 25, 2015

Choose a reason for hiding this comment

jfischer-no commented Jul 9, 2015

jfischer-no commented Jul 9, 2015

jnohlgard commented Jul 9, 2015

zhuoshuguo commented Jan 23, 2016

jnohlgard commented Jul 12, 2016

miri64 commented Jan 13, 2017

smlng commented Mar 6, 2017

PeterKietzmann commented Mar 28, 2017

maribu commented Jun 4, 2020