Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-actions: bump deprecated packages #20892

Merged
merged 2 commits into from
Oct 7, 2024
Merged

gh-actions: bump deprecated packages #20892

merged 2 commits into from
Oct 7, 2024

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 7, 2024

Contribution description

See https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/ and also latest release-tests run.

Testing procedure

Confirm the new versions exist:

... and review. We can also start the worflows in question, if the reviewer thinks it is needed.

Issues/PRs references

None.

@miri64 miri64 added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Oct 7, 2024
@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Oct 7, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 7, 2024
@riot-ci
Copy link

riot-ci commented Oct 7, 2024

Murdock results

✔️ PASSED

873e7e3 gh-actions: bump webfactory/ssh-agent to v0.9.0

Success Failures Total Runtime
1 0 1 01m:08s

Artifacts

@benpicco benpicco changed the title Gh actions/fix/bump deprecated gh-actions: bump deprecated packages Oct 7, 2024
mguetschow
mguetschow approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the testing procedure in the PRs description, LGTM. I guess we can just merge and would see failing release tests next weekend anyway. Thank you!

@mguetschow mguetschow enabled auto-merge October 7, 2024 11:15
@mguetschow mguetschow added this pull request to the merge queue Oct 7, 2024
Merged via the queue into RIOT-OS:master with commit e56b052 Oct 7, 2024
29 checks passed
@miri64 miri64 deleted the gh-actions/fix/bump-deprecated branch October 8, 2024 06:34
@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

@benpicco benpicco Awaiting requested review from benpicco

@Teufelchen1 Teufelchen1 Awaiting requested review from Teufelchen1

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miri64 @riot-ci @mguetschow @benpicco