Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-actions: remove reporting release tests to Matrix #19879

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Aug 12, 2023

Contribution description

Reporting the release tests to Matrix never really worked and currently it makes the release tests look like failing. So lets just remove this action.

This effectively reverts commits 9810070 and 764f7f0.

Testing procedure

Release tests should still work... we can start a run, but since this just reverts the to commits that added this which are the two last changes in the log to tha workflow file, I am pretty confident that this does not break anything:

$ git log upstream/master -- .github/workflows/release-test.yml
commit 98100704ab74a7163bb2a32c4d1d4c25a6ad588a
Author: Martine Lenders <m.lenders@fu-berlin.de>
Date:   Sat Jan 14 09:49:52 2023 +0100

    release-tests: fix PASSED chat message

commit 764f7f0bf4cff93676f830e5bad441e534a20b1e
Author: Martine Lenders <m.lenders@fu-berlin.de>
Date:   Fri Jan 6 14:24:17 2023 +0100

    gh-actions: report release-tests result to Matrix

commit 37be7b9420c5735968139e6261e1e7b1b990629c
Author: Martine Lenders <m.lenders@fu-berlin.de>
Date:   Thu Oct 13 18:05:07 2022 +0200

    Revert "release-tests: add capability to run on PR comment"

[...]

Issues/PRs references

Reverts #19102 and #19145.

@miri64 miri64 added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Aug 12, 2023
@miri64 miri64 requested a review from maribu August 12, 2023 09:29
@github-actions github-actions bot added the Area: CI Area: Continuous Integration of RIOT components label Aug 12, 2023
@miri64 miri64 added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 12, 2023
@riot-ci
Copy link

riot-ci commented Aug 12, 2023

Murdock results

✔️ PASSED

fec3c24 gh-actions: remove reporting release tests to Matrix

Success Failures Total Runtime
1 0 1 59s

Artifacts

@miri64
Copy link
Member Author

miri64 commented Aug 12, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 12, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 210c4f4 into RIOT-OS:master Aug 12, 2023
@miri64 miri64 deleted the gh-actions/remove/matrix-notification branch August 12, 2023 10:29
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants