gnrc/ipv6/nib: fix 6Lo ND options on non 6Lo interface #19604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a 6Lo router sends and RA over a non-6Lo interface it should not include the options which are specifically for 6Lo ND
fabian18
requested review from
miri64,
haukepetersen,
PeterKietzmann and
cgundogan
as code owners
|
@miri64 :) |
benpicco
added
the
CI: ready for build
benpicco
approved these changes
May 22, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
fabian18
deleted the
pr/dont_include_6lo_nd_options_on_non_6lo_interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
We have put a Raspberry Pi behind a 6Lo network and discovered that the 6Lo router includes the 6Lo ND options in router advertisements over the non sixlowpan interface to the Pi.
This behaviour is probably not useful/intended. So we check if the interface over which the RA is sent, is a 6Lo interface before the 6Lo ND options are appended.
Testing procedure
Our setup is Raspi --> 6LBR --> 6LR --> Raspi
Issues/PRs references
alternative to #17594