-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shell/cmds: add genfile command #19401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only nits.
Side note: The usage of vfs on native is confusing and poorly documented. I did not succeed to properly tests this 🤡
bors merge |
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Contribution description
Often it is quite handy to have a file with a known and easy to inspect content for transmission tests.
This adds a
genfile
command where a file with set number of rows (blocks) of varying size can be generated.It is easy to visually identify corruptions to this file patter.
Testing procedure
The command has been added to
tests/vfs_default
:Issues/PRs references