Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/init: add early_init() #19082

Merged
merged 3 commits into from
Jan 13, 2023
Merged

core/init: add early_init() #19082

merged 3 commits into from
Jan 13, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Jan 2, 2023

Contribution description

Currently each stdio implementation has to call vfs_bind_stdio() and LEDs are initialized after stdio.

Fix this by introducing a new early_init() function that takes care of initializing debug LEDs and stdio as well as binding it to VFS.

Testing procedure

stdio should function as before - the call was just moved behind LED init.

Issues/PRs references

@benpicco benpicco added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Jan 2, 2023
@github-actions github-actions bot added Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: USB Area: Universal Serial Bus Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: AVR Platform: This PR/issue effects AVR-based platforms Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jan 2, 2023
@benpicco
Copy link
Contributor Author

benpicco commented Jan 3, 2023

bors try

bors bot added a commit that referenced this pull request Jan 3, 2023
@bors
Try #19082:
577afbd
@bors
Copy link
Contributor

bors bot commented Jan 3, 2023

try

Build failed:

@benpicco benpicco force-pushed the early_init branch 2 times, most recently from ebd8329 to 5eecded Compare January 3, 2023 22:48
@benpicco
Copy link
Contributor Author

benpicco commented Jan 3, 2023

bors try

bors bot added a commit that referenced this pull request Jan 3, 2023
@bors
Try #19082:
fac7a7c
@bors
Copy link
Contributor

bors bot commented Jan 4, 2023

try

Build succeeded:

@kaspar030 kaspar030 added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 8, 2023
@kaspar030
Copy link
Contributor

please rebase!

kaspar030
kaspar030 approved these changes Jan 8, 2023
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@riot-ci
Copy link

riot-ci commented Jan 9, 2023 •
edited
Loading

Murdock results

✔️ PASSED

59f0671 core/init: call vfs_bind_stdio() in early_init()

Success Failures Total Runtime
6770 0 6770 13m:31s

Artifacts

@kaspar030
Copy link
Contributor

I've disabled pi-c06df873 (which seems to get stuck) and restarted the build.

@benpicco benpicco removed CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: no fast fail don't abort PR build after first error labels Jan 13, 2023
@benpicco
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

👎 Rejected by PR status

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 13, 2023
@benpicco
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 13, 2023

Build succeeded:

@bors bors bot merged commit fb603f2 into RIOT-OS:master Jan 13, 2023
@benpicco benpicco deleted the early_init branch January 13, 2023 17:12
@jia200x jia200x added this to the Release 2023.04 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

@bergzand bergzand Awaiting requested review from bergzand bergzand is a code owner

@dylad dylad Awaiting requested review from dylad dylad is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@haukepetersen haukepetersen Awaiting requested review from haukepetersen

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@cgundogan cgundogan Awaiting requested review from cgundogan

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

@DipSwitch DipSwitch Awaiting requested review from DipSwitch

@vincent-d vincent-d Awaiting requested review from vincent-d vincent-d is a code owner

@biboc biboc Awaiting requested review from biboc biboc is a code owner

@gschorcht gschorcht Awaiting requested review from gschorcht gschorcht is a code owner

@basilfx basilfx Awaiting requested review from basilfx basilfx is a code owner

@smlng smlng Awaiting requested review from smlng

@kYc0o kYc0o Awaiting requested review from kYc0o kYc0o is a code owner

@maribu maribu Awaiting requested review from maribu maribu is a code owner

@nandojve nandojve Awaiting requested review from nandojve nandojve is a code owner

Assignees
No one assigned
Labels
Area: core Area: RIOT kernel. Handle PRs marked with this with care! Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers Area: network Area: Networking Area: pkg Area: External package ports Area: sys Area: System Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Platform: AVR Platform: This PR/issue effects AVR-based platforms Platform: ESP Platform: This PR/issue effects ESP-based platforms Platform: MSP Platform: This PR/issue effects MSP-based platforms Platform: native Platform: This PR/issue effects the native platform Platform: RISC-V Platform: This PR/issue effects RISC-V-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.04
Development

Successfully merging this pull request may close these issues.
5 participants
@benpicco @maribu @kaspar030 @riot-ci @jia200x