vfs: drop unused abs_path parameter #18672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
github-actions
bot
added
Area: pkg
benpicco
added
Type: cleanup
Murdock results✔️ PASSED 85dd564 vfs: drop unused abs_path parameter This only reflects a subset of all builds from https://ci-prod.riot-os.org. Please refer to https://ci.riot-os.org for a complete build for now. |
benpicco
force-pushed
the
vfs-abs_path
branch
from
1028409 to
85dd564
Compare
chrysn
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Looks good to me (did not test, CI suffices here).
I think these are remnants of what could have become a current-working-directory or an openat-style system, but it was neither done consistently nor taken up, so let's drop it.
(I would support something openat-style, but what is removed here is IMO not a good base for that.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Both
open()andopendir()also get the absolute path in VFS.This is used by no filesystem and worse, only present for those two functions.
So even if a filesystem would rely on the absolute path, it could not
mkdir,unlinkorrenamefiles.Remove it as it only adds clutter and confusion.
Testing procedure
CI should be enough, this parameter was unused by every implementation.
Issues/PRs references