Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/avr8_common: add strings.h for compatibility #18623

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

maribu
Copy link
Member

@maribu maribu commented Sep 22, 2022

Contribution description

This adds strings.h missing in AVR libc and implements the most commonly used functions in it (which are all trivial).

Testing procedure

The functions are trivial enough that code review should be sufficient. But I could add a test application, if reviewers would prefer.

Issues/PRs references

Noticed due to Murdock failures in #18621

@maribu maribu requested a review from kYc0o as a code owner September 22, 2022 06:36
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Platform: AVR Platform: This PR/issue effects AVR-based platforms labels Sep 22, 2022
@maribu
Copy link
Member Author

maribu commented Sep 22, 2022

@benpicco I wonder if it would make sense to cherry pick the commit here into #18621 - I would actually like to add a few lines of unit tests to ensure consistent behavior among C libs, but I rather have that in the test app #18621 introduced.

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 23, 2022
@benpicco benpicco enabled auto-merge September 23, 2022 12:00
@benpicco benpicco merged commit a0ddf00 into RIOT-OS:master Sep 23, 2022
@maribu
Copy link
Member Author

maribu commented Sep 23, 2022

Thx :)

@maribu maribu deleted the cpu/avr8_common/strings branch September 23, 2022 19:01
@maribu maribu added this to the Release 2022.10 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: AVR Platform: This PR/issue effects AVR-based platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants