Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu/esp32: add ESP-IDF API #18253

Merged
merged 2 commits into from
Jun 26, 2022
Merged

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR is a split-off from PR #17841. It adds the basic structure for an API which is used for ESP-IDF types and functions that are required by RIOT-OS but cannot be included directly due to naming conflicts.

For this purpose, the header files of this API declare the types and functions that are required from the ESP-IDF, but without using the ESP-IDF header files to avoid conflicting names. The implementation of the API then uses the ESP-IDF. In most cases, simple wrapper functions are sufficient.

Testing procedure

Since the basic structure of the API contains almost no functionality, a green CI is sufficient.

Issues/PRs references

Split-off from PR #17841

Implements an interface for ESP-IDF types and functions that are required by RIOT-OS but cannot be included directly due to name conflicts.
f
@gschorcht gschorcht requested a review from benpicco June 23, 2022 14:26
@github-actions github-actions bot added Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 23, 2022
@gschorcht gschorcht added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: doc Area: Documentation Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration and removed Area: doc Area: Documentation Platform: ESP Platform: This PR/issue effects ESP-based platforms Area: cpu Area: CPU/MCU ports Area: Kconfig Area: Kconfig integration labels Jun 23, 2022
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes it painfully clear why namespaces would sometimes be a good thing to have…

I hope we can enable LTO one day so this at least wouldn't add any run-time cost anymore.

@gschorcht
Copy link
Contributor Author

@benpicco Can we merge this one? It should then be possible to prepare the PRs for peripherals independent of other PRs once this PR is merged.

@benpicco benpicco merged commit dd574a4 into RIOT-OS:master Jun 26, 2022
@gschorcht
Copy link
Contributor Author

@benpicco Thanks for reviewing and merging.

@gschorcht
Copy link
Contributor Author

It should then be possible to prepare the PRs for peripherals independent of other PRs once this PR is merged.

Unfortunately this is not possible after all. The function esp_intr_get_cpu is needed, which is provided by PR #18261. So we have to wait for this PR.

@gschorcht gschorcht deleted the cpu/esp32/add_esp_idf_api branch June 28, 2022 14:52
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: cpu Area: CPU/MCU ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants