-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/esp32: add ESP-IDF API #18253
cpu/esp32: add ESP-IDF API #18253
Conversation
Implements an interface for ESP-IDF types and functions that are required by RIOT-OS but cannot be included directly due to name conflicts. f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes it painfully clear why namespaces would sometimes be a good thing to have…
I hope we can enable LTO one day so this at least wouldn't add any run-time cost anymore.
@benpicco Can we merge this one? It should then be possible to prepare the PRs for peripherals independent of other PRs once this PR is merged. |
@benpicco Thanks for reviewing and merging. |
Unfortunately this is not possible after all. The function |
Contribution description
This PR is a split-off from PR #17841. It adds the basic structure for an API which is used for ESP-IDF types and functions that are required by RIOT-OS but cannot be included directly due to naming conflicts.
For this purpose, the header files of this API declare the types and functions that are required from the ESP-IDF, but without using the ESP-IDF header files to avoid conflicting names. The implementation of the API then uses the ESP-IDF. In most cases, simple wrapper functions are sufficient.
Testing procedure
Since the basic structure of the API contains almost no functionality, a green CI is sufficient.
Issues/PRs references
Split-off from PR #17841