Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/ws281x: update ESP32 driver to use ESP-IDF CPU HAL #18252

Merged
merged 1 commit into from
Jun 25, 2022
Merged

drivers/ws281x: update ESP32 driver to use ESP-IDF CPU HAL #18252

merged 1 commit into from
Jun 25, 2022

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR is a splitt-off from PR #17841. It updates the ESP32 driver to use ESP-IDF CPU HAL.

Testing procedure

  1. Green CI
  2. If the hardware is at hand, compile and test it with: 
    BOARD=esp32-wroom-32 make -C tests/driver_ws281x flash term

Issues/PRs references

Split-off from PR #17841.

@gschorcht gschorcht requested a review from maribu as a code owner June 23, 2022 14:00
@github-actions github-actions bot added the Area: drivers Area: Device drivers label Jun 23, 2022
@gschorcht gschorcht added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms labels Jun 23, 2022
@gschorcht gschorcht mentioned this pull request Jun 23, 2022
Closed
maribu
maribu approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Change is so unscary this IMO doesn't need testing.

Thanks for porting this driver to the newer ESP32 family members :)

@gschorcht
Copy link
Contributor Author

Hm, tests on CircleCI failed due to timeouts. Is there any way to retrigger these tests?

@maribu
Copy link
Member

maribu commented Jun 24, 2022

The two Murdock failures are again unrelated glitches with mismatching hashes. I'll re-run Murdock without compile tests this time.

The circle-ci stuff failure is also unrelated and if I recall correctly, is just informative only. I will restart them if I remember wrong, but I guess we can just leave them in failed state and merge anyway.

@maribu maribu added CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 24, 2022
@benpicco benpicco merged commit 32a1c22 into RIOT-OS:master Jun 25, 2022
@gschorcht
Copy link
Contributor Author

@maribu @benpicco Thanks for reviewing and merging.

@gschorcht gschorcht deleted the cpu/esp32/update_ws281x branch June 25, 2022 22:53
@chrysn chrysn added this to the Release 2022.07 milestone Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2022.07
Development

Successfully merging this pull request may close these issues.
4 participants
@gschorcht @maribu @chrysn @benpicco