Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rudimentary support for i.MX6 and the RIoTboard (SWP telematics) #1411

Closed
wants to merge 2 commits into from
Closed

add rudimentary support for i.MX6 and the RIoTboard (SWP telematics) #1411

wants to merge 2 commits into from

Conversation

yogo1212
Copy link
Contributor

This is a PR for concluding the telematics softwareproject 2014.

We plan to improve the quality of and continue working on this port in the future.

yogo1212 added 2 commits July 13, 2014 23:59
@yogo1212
cpu: added support for the i.MX6 (SWP)
d0362a5
@yogo1212
board: initial commit for the RIoTboard (SWP)
b1082bc 
    Adds basic (the most "basic" you can think of) support of the RIoTboard to RIoT-OS.
    In this case "basic" means: The UART(I/O) is working, it's possible to include the automatically generated sources from the IOMUX-Config-tool. Timers are implemented. Threading isn't.
    Currently, there is a while(1)-loop in board init to prevent weird stuff from happening when progressing to kernel_init.
    This port is based entirely on the official platform-SDK from freescale.
    The overall quality is not what it should be.

    We intend to continue working on this stuff till it's working properly and the code is cleaned up.
@Kijewski Kijewski added this to the Release NEXT MAJOR milestone Jul 13, 2014
@Kijewski Kijewski added the WIP label Jul 13, 2014
@Kijewski
Copy link
Contributor

Strong NAK. 397528 added lines is unacceptable. I can't find the files that you wrote in this vast amount of code.

Your board's Makefile.include should download the SDK code on the fly. Take boards/x86-multiboot-common/Makefile.include as an example how to do that.

@haukepetersen
Copy link
Contributor

Agree with @Kijewski! If the SDK is this huge, a solution that downloads it via Makefile make more sense. Also I think there are limitless files in this PR which you don't really need for RIOT @ Riotboard?!

@yogo1212
Copy link
Contributor Author

I know that. BUT: The SDK had to be altered heavily (conflicting names, different entry points in the linker script, bad options, the SDK already having an abstraction for boards/cpu, etc.).

Without doubt, the SDK will have to be changed (at least to add a RIoTboard-target - but why would that happen in the cpu-module in RIoT?) after the download.
I agree that - in principle - downloading the code that has not been written for RIoT is the nicer approach.

Right now, there are a lot of exams. Give me a month of time and I'll probably figure something out

@thomaseichinger
Copy link
Member

@yogo1212 First of all, congratulations for finishing your SWP!
Regarding this PR:

  1. In the current state it isn't reviewable. I'd suggest you either take a look at @Kijewski's method or put a Makefile in pkg/i.MX6_sdk/ or similar to handle this problem. This way it will be downloaded at compile time and you can patch the sources as you need to. Same will probably be the way for include/registers/*. But I think we'll have to find a solution for these in general because I think the register definition files bloat RIOT's repo.
  2. Please move your dependencies from Makefile.dep to boards/riotboard/Makefile.dep.
  3. Change (especially) doxygen and license headers to reflect your authorship and correct board/cpu.

These are the hints I can give right now (taking the files into account that where displayed to me)

@yogo1212
Copy link
Contributor Author

@thomaseichinger thank you

  1. I'll figure something out
    {2;3}. consider it done

@miri64 miri64 modified the milestones: FU-SWP summer 2014, Release NEXT MAJOR Jul 15, 2014
@LudwigKnuepfer LudwigKnuepfer mentioned this pull request Jul 15, 2014
Closed
@thomaseichinger
Copy link
Member

closing this in favour of #1452

@OlegHahm OlegHahm mentioned this pull request Aug 11, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@haukepetersen haukepetersen

Labels
State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yogo1212 @Kijewski @haukepetersen @thomaseichinger @miri64