Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_nettype: deprecate IOVEC type #13170

Merged
merged 1 commit into from
Jan 20, 2020
Merged

gnrc_nettype: deprecate IOVEC type #13170

merged 1 commit into from
Jan 20, 2020

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jan 20, 2020

Contribution description

It is unused since #11193 and not expected to be re-used in the future.

Testing procedure

With make doc it should show up in deprecated.html.

Issues/PRs references

None

@miri64 miri64 added Area: network Area: Networking Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Jan 20, 2020
@miri64 miri64 added this to the Release 2020.04 milestone Jan 20, 2020
@miri64 miri64 requested a review from haukepetersen January 20, 2020 11:03
haukepetersen
haukepetersen approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@haukepetersen haukepetersen added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 20, 2020
@miri64
gnrc_nettype: deprecate iovec type
744f078 
It is unused since 9fb2f54 and not
expected to be re-used in the future.
@miri64 miri64 force-pushed the gnrc_nettype/clean/iovec branch from 64f14e7 to 744f078 Compare January 20, 2020 12:39
@miri64
Copy link
Member Author

miri64 commented Jan 20, 2020

Some people won't test :P. Luckily both Travis and Murdock spotted the typo I fixed in the latest amendment.

@miri64 miri64 merged commit 9999cec into RIOT-OS:master Jan 20, 2020
@miri64 miri64 deleted the gnrc_nettype/clean/iovec branch January 20, 2020 14:21
@miri64 miri64 mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haukepetersen haukepetersen haukepetersen approved these changes

Assignees
No one assigned
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @haukepetersen