Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrfusb: Check chip revision before enabling #12178

Merged
merged 1 commit into from
Sep 6, 2019
Merged

nrfusb: Check chip revision before enabling #12178

merged 1 commit into from
Sep 6, 2019

Conversation

bergzand
Copy link
Member

@bergzand bergzand commented Sep 6, 2019

Contribution description

Engineering sample A doesn't have a functional USB peripheral (errata
issue 94). This commit adds an assertion check for this revision to
prevent some developer headaches.

Testing procedure

Find an engineering revision A board and flash examples/usbus_minimal on it. It should throw an assertion failure on boot. It must not throw an assertion failure on any other version.

Issues/PRs references

None

@bergzand
nrfusb: Check chip revision before enabling
a5c594a 
Engineering sample A doesn't have a functional USB peripheral (errata
issue 94). This commit adds an assertion check for this revision to
prevent some developer headaches.
@bergzand bergzand added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: USB Area: Universal Serial Bus labels Sep 6, 2019
@bergzand bergzand added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 6, 2019
haukepetersen
haukepetersen approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on reel and nrf52840dk, the latter being one of the effected engineering samples. The reel works just fine, while my dk triggers this new assertion -> so everything working as expected.

ACK

@haukepetersen haukepetersen added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Sep 6, 2019
@bergzand bergzand merged commit bcdec16 into RIOT-OS:master Sep 6, 2019
@bergzand
Copy link
Member Author

bergzand commented Sep 6, 2019

@haukepetersen Thanks!

@bergzand bergzand deleted the pr/nrfusb/check_rev branch September 6, 2019 08:33
@kb2ma kb2ma added this to the Release 2019.10 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haukepetersen haukepetersen haukepetersen approved these changes

Assignees
No one assigned
Labels
Area: USB Area: Universal Serial Bus CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2019.10
Development

Successfully merging this pull request may close these issues.
3 participants
@bergzand @haukepetersen @kb2ma