tests/unittests: chunked_ringbuffer: add test for half-written chunk

RIOT-OS · Dec 12, 2024 · 3d16d4b · 3d16d4b
1 parent d39c769
commit 3d16d4b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/sys/include/chunked_ringbuffer.h b/sys/include/chunked_ringbuffer.h
@@ -90,6 +90,8 @@ bool crb_end_chunk(chunk_ringbuf_t *rb, bool valid);
 /**
  * @brief Start a new chunk on the ringbuffer
  *
+ * If an unfinished chunk already exists, it will be discarded.
+ *
  * @note  This function is expected to be called in ISR context / with
  *        interrupts disabled.
  *

diff --git a/tests/unittests/tests-chunked_ringbuffer/tests-chunked_ringbuffer.c b/tests/unittests/tests-chunked_ringbuffer/tests-chunked_ringbuffer.c
@@ -25,6 +25,12 @@ static void test_crb_add_and_consume(void)
 
     crb_init(&cb, buffer, sizeof(buffer));
 
+    /* add a chunk but don't finish it */
+    crb_start_chunk(&cb);
+    crb_add_byte(&cb, 1);
+    crb_add_byte(&cb, 2);
+    crb_add_byte(&cb, 3);
+
     TEST_ASSERT(crb_add_chunk(&cb, "one", 4));
     TEST_ASSERT(crb_add_chunk(&cb, "two", 4));
     TEST_ASSERT(crb_add_chunk(&cb, "three", 6));