Specify Optional parameters in Graph.triples_choices
#3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two non-list parameters can be `None`, but this is not reflected in the type hint. Also introduces a type alias to simplify method signatures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Change the typing of
Graph.triples_choicesandStore.triples_choisesto match the actual types allowed by the code.
The two non-list parameters can be
None, but this is not reflected inthe type hint today.
Introduce a type alias to simplify method signatures, and update all
overloads of
triples_choisesto use this alias.Checklist
the same change.
pytest -m "not webtest"), since I could not get them working at all.7266 passed, 61 skipped, 333 deselected, 330 xfailed, 36 xpassed, 6925 warningsso maintainers can fix minor issues and keep your PR up to date.