Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes to SpacePrez search interface #44

Merged
merged 1 commit into from
May 1, 2023
Merged

Bug fixes to SpacePrez search interface #44

merged 1 commit into from
May 1, 2023

Conversation

hjohns
Copy link
Collaborator

@hjohns hjohns commented Apr 27, 2023

Updates to SpacePrez search

  • Area type defaults to Nearby for points and Contains for areas
  • Search button bug fixed
  • Search loading feedback
  • Updates to SPARQL query to remove filters
  • Duplicate search request issue

jamiefeiss
jamiefeiss approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@jamiefeiss jamiefeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only thing I'd suggest is to make the map search responsive to the screen width, as the results table can go off-screen

@recalcitrantsupplant
Copy link
Collaborator

Merging as I need these changes in the repo. Have created #46. Are you able to add Howard as a contributor or the like Jamie so he can create/push to branches in the repo rather than a fork?

@recalcitrantsupplant recalcitrantsupplant merged commit e4ec39e into RDFLib:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiefeiss jamiefeiss jamiefeiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjohns @recalcitrantsupplant @jamiefeiss