API request refactor #100
Merged
API request refactor #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmondchuc
previously approved these changes
Aug 30, 2023
…al search Pinia stores
Spatial search requests refactor
edmondchuc
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the fetch request composables to use
async/awaitinstead of callback functions. Error handling has also been improved, andapi.tsnow contains four composables to use:useGetRequest(): Does a generic GET request using thefetchAPI. This is designed to be used for any non-Prez API & non-SPARQL GET requests if needed.useApiRequest(): Does a GET request to the Prez API. Profiles are automatically parsed from the Link headers, and it expects atext/anot+turtleresponse. This is the composable pretty much every page uses to talk to the Prez API.useConcurrentApiRequests(): Basically a parallel version ofuseApiRequest(), where you provide an array of URLs. In response you get an array of responses that contain the data and profiles for each individual request.useSparqlRequest(): Does a SPARQL GET request (not specific to the Prez API). The composable will automatically determine if the response will be JSON ortext/turtlebased on the query.The
AltView.vuecomponent has been removed as it's not being used as it has been replaced withProfilesTable.vue.