Improve performance of src_analyse_IRSARRF_SRS() with optimization at -O2 #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… -O2. These changes improve the running time of our example when using -O2, which is the default compilation flag on CRAN. This is a mild regression for the -O3 flag, but given that hardly anybody will use that, the compromise seems worth it. Single core performance using 3 slide windows: - with -O2 time goes from 13.5s to 10.7s - with -03 time goes from 10.1s to 10.7s Single core performance using 10 slide windows: - with -O2 time goes from 40.9s to 32.6s - with -03 time goes from 29.1s to 32.5s
|
Thanks @mcol, great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes improve the running time of our example when using -O2, which is the default compilation flag on CRAN. This is a mild regression for the -O3 flag, but given that hardly anybody will use that, the compromise seems worth it. Part of #372.
Single core performance using 3 slide windows:
Single core performance using 10 slide windows: