Remove the dependency on the readxl package #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RLumSK
requested changes
Sep 26, 2024
We call fread() with argument data.table = FALSE to return directly a data.frame, and restore support for the skip option.
RLumSK
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the changes in the snapshot file for
.import_ThermochronometryData()boil down to differences betweenCLBR IR50(before) andCLBR_IR50(now) because names were before taken from the XLS sheet names while now they are taken from the CSV file names, and when I generated them I used the underscore instead of a space. All the rest is perfectly reproduced.Fixes #237.