Selective acceptance of recent PRs to Qortal master branch, and updated start.sh script. See description for details. #241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a modification of the current master branch that selectively excludes the network and dependency changes by Alpha due to tests showing less peer connection time, and lower peer count. The additional changes didn't seem like they could cause such issues, but they did anyway.
This PR keeps everything else, including the display of the real minter address in the API calls, and other modifications by @kennycud, @AlphaX-Qortal, @Philreact and @QuickMythril.
This pull also includes a modification to start.sh to enforce utilization of G1GC Garbage Collector by default, and set the potential 'max RAM' to 50%. G1GC is a multi-threaded Garbage Collector that is more optimal for the recent changes made by @kennycud, and should make Garbage Collection much more efficient. Also sets Xss to 1024k based on long-term testing. (NOTE - this does NOT mean that the machine WILL use 50% of available RAM for Qortal, it just ALLOWS Qortal to POTENTIALLY utilize UP TO 50%, which should allow machines with as low as 6GB of RAM to run the core without issue. Machines with more available RAM will not dedicate more than the JVM requires, but will potentially dedicate up to 50%. This number can be modified in JVM_MEMORY_ARGS variable in the script if users prefer something else. ALSO NOTE - G1GC defaults on WINDOWS machines will require a modification to the windows .ini file created by AdvancedInstaller. This change is being worked on as well. It is possible that a manual modification of the ini without a re-installation will work as well, but this has yet to be officially tested. Once the testing is completed we will verify this and make announcements.)
Additional changes to start.sh to include various other memory settings for container-based nodes and other specific additions will be made in the future.