Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective acceptance of recent PRs to Qortal master branch, and updated start.sh script. See description for details. #241

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

crowetic
Copy link
Member

@crowetic crowetic commented Dec 4, 2024

This is a modification of the current master branch that selectively excludes the network and dependency changes by Alpha due to tests showing less peer connection time, and lower peer count. The additional changes didn't seem like they could cause such issues, but they did anyway.

This PR keeps everything else, including the display of the real minter address in the API calls, and other modifications by @kennycud, @AlphaX-Qortal, @Philreact and @QuickMythril.

This pull also includes a modification to start.sh to enforce utilization of G1GC Garbage Collector by default, and set the potential 'max RAM' to 50%. G1GC is a multi-threaded Garbage Collector that is more optimal for the recent changes made by @kennycud, and should make Garbage Collection much more efficient. Also sets Xss to 1024k based on long-term testing. (NOTE - this does NOT mean that the machine WILL use 50% of available RAM for Qortal, it just ALLOWS Qortal to POTENTIALLY utilize UP TO 50%, which should allow machines with as low as 6GB of RAM to run the core without issue. Machines with more available RAM will not dedicate more than the JVM requires, but will potentially dedicate up to 50%. This number can be modified in JVM_MEMORY_ARGS variable in the script if users prefer something else. ALSO NOTE - G1GC defaults on WINDOWS machines will require a modification to the windows .ini file created by AdvancedInstaller. This change is being worked on as well. It is possible that a manual modification of the ini without a re-installation will work as well, but this has yet to be officially tested. Once the testing is completed we will verify this and make announcements.)

Additional changes to start.sh to include various other memory settings for container-based nodes and other specific additions will be made in the future.

…available in version 4.6.6 and beyond. Suggestion to machines with 6GB of RAM or less, increase the percentage from 50 to 75. Qortal Core will only utilize the RAM it needs, up to the percentage set maximum.
Copy link
Member Author

@crowetic crowetic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous merges to master were done without enough testing, apologies for that. This PR should prevent the peer-count and connection time related issues that were noticed on a few tester nodes. This PR has been being tested for 24-48 hours and has been given to the community for further review.

This is essentially just a 'cherry pick' of some changes in the master commits, but not all of them. Only the network and dependency update changes from AlphaX were not included, all of Alpha's additional changes, Phil, kenny, and Quick were all included.

@crowetic crowetic merged commit 749143e into Qortal:master Dec 4, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant